vmstat: Add root element to libxo output #1330
Conversation
Current libxo output does not have a root element. Valid XML requires a single root element. This commit adds this root element. PR: 254635 Pull Request: freebsd#1330
bramton
changed the title
bramton
changed the title
Current libxo output does not have a root element. Valid XML requires a single root element. This commit adds this root element. PR: 254635 Pull Request: freebsd#1330
|
I wonder if such change would warrant a version bump? |
|
Agreed. Version number has been bumped. |
|
I think this is fine... In an ideal world, we'd document the schemas and versions in the man page, but that's not done elsewhere. |
|
This looks good to me, thank you. The two commits can be squashed together IMO.
As far as I know, we don't have any documented conventions beyond what's in the libxo documentation itself. I do think it makes sense to have a root element, and that's what most programs do. It would be nice to document these version bumps in the man page as well, explaining what changed, etc., but I think this patch is ok as it is. |
Current libxo output does not have a root element. Valid XML requires a single root element. This commit adds this root element. libxo output version bumped accordingly. PR: 254635 Pull Request: freebsd#1330
Done! |
|
Merged as c7dd97e , thanks! |
Current libxo output does not have a root element. Valid XML requires a single root element. This commit adds this root element. The libxo output version bumped accordingly. PR: 254635 MFC after: 1 week Pull Request: #1330
Partial fix for Bug 254635.
On a side note: The conventions around libxo output seem to be a bit inconsistent. For instance
netstatandjlsdo not use the program name as root element, but usestatisticsandjail-informationinstead. Theprocstatprogram uses thegetprogname()function to set the name of the root element, whilstarphard codes the program name. What are the best practices regarding libxo output?